Polymorphic list and pointers











up vote
1
down vote

favorite












I am new to C++ and am struggling on polymorphism.
I have a project where I need to have a base class (let's say Master) and three derived class.



class Master {
public :
virtual void run();
//Other attributes non-important for the topic
}

class Derived1 : public Master {
public:
void run();
//attributes
}

class Derived2 : public Master{
public :
Derived2(Derived1* ptr1) {ptr = ptr1;} //there comes the cause of the problem
void run();
private :
Derived1* ptr;
}


In my main I want to create a polymorphic list vector<Master*> poly_list;
But the problem is that this list only contains pointers on the Master class so even if it could call the right function run(); I cannot send the address of Derived1 to the constructor of Derived2.



I wanted to proceed like this :



int main
{
vector<Master*> poly_list;
poly_list.push_back(new Derived1());
poly_list.push_back(new Derived2(poly_list[0]));

return 0
}


And when I compile the code the compiler tells me that it cannot convert type Master to Derived1 for the constructor.



Anybody has a way for this to work ? Thanks by advance.










share|improve this question


























    up vote
    1
    down vote

    favorite












    I am new to C++ and am struggling on polymorphism.
    I have a project where I need to have a base class (let's say Master) and three derived class.



    class Master {
    public :
    virtual void run();
    //Other attributes non-important for the topic
    }

    class Derived1 : public Master {
    public:
    void run();
    //attributes
    }

    class Derived2 : public Master{
    public :
    Derived2(Derived1* ptr1) {ptr = ptr1;} //there comes the cause of the problem
    void run();
    private :
    Derived1* ptr;
    }


    In my main I want to create a polymorphic list vector<Master*> poly_list;
    But the problem is that this list only contains pointers on the Master class so even if it could call the right function run(); I cannot send the address of Derived1 to the constructor of Derived2.



    I wanted to proceed like this :



    int main
    {
    vector<Master*> poly_list;
    poly_list.push_back(new Derived1());
    poly_list.push_back(new Derived2(poly_list[0]));

    return 0
    }


    And when I compile the code the compiler tells me that it cannot convert type Master to Derived1 for the constructor.



    Anybody has a way for this to work ? Thanks by advance.










    share|improve this question
























      up vote
      1
      down vote

      favorite









      up vote
      1
      down vote

      favorite











      I am new to C++ and am struggling on polymorphism.
      I have a project where I need to have a base class (let's say Master) and three derived class.



      class Master {
      public :
      virtual void run();
      //Other attributes non-important for the topic
      }

      class Derived1 : public Master {
      public:
      void run();
      //attributes
      }

      class Derived2 : public Master{
      public :
      Derived2(Derived1* ptr1) {ptr = ptr1;} //there comes the cause of the problem
      void run();
      private :
      Derived1* ptr;
      }


      In my main I want to create a polymorphic list vector<Master*> poly_list;
      But the problem is that this list only contains pointers on the Master class so even if it could call the right function run(); I cannot send the address of Derived1 to the constructor of Derived2.



      I wanted to proceed like this :



      int main
      {
      vector<Master*> poly_list;
      poly_list.push_back(new Derived1());
      poly_list.push_back(new Derived2(poly_list[0]));

      return 0
      }


      And when I compile the code the compiler tells me that it cannot convert type Master to Derived1 for the constructor.



      Anybody has a way for this to work ? Thanks by advance.










      share|improve this question













      I am new to C++ and am struggling on polymorphism.
      I have a project where I need to have a base class (let's say Master) and three derived class.



      class Master {
      public :
      virtual void run();
      //Other attributes non-important for the topic
      }

      class Derived1 : public Master {
      public:
      void run();
      //attributes
      }

      class Derived2 : public Master{
      public :
      Derived2(Derived1* ptr1) {ptr = ptr1;} //there comes the cause of the problem
      void run();
      private :
      Derived1* ptr;
      }


      In my main I want to create a polymorphic list vector<Master*> poly_list;
      But the problem is that this list only contains pointers on the Master class so even if it could call the right function run(); I cannot send the address of Derived1 to the constructor of Derived2.



      I wanted to proceed like this :



      int main
      {
      vector<Master*> poly_list;
      poly_list.push_back(new Derived1());
      poly_list.push_back(new Derived2(poly_list[0]));

      return 0
      }


      And when I compile the code the compiler tells me that it cannot convert type Master to Derived1 for the constructor.



      Anybody has a way for this to work ? Thanks by advance.







      polymorphism






      share|improve this question













      share|improve this question











      share|improve this question




      share|improve this question










      asked Nov 17 at 13:20









      Ulysse Touchais

      84




      84
























          1 Answer
          1






          active

          oldest

          votes

















          up vote
          0
          down vote



          accepted










          Yes, take a pointer of Derived1 before pushing it into the list:



          vector<Master*> poly_list;

          Derived1 *d=new Derived1();
          poly_list.push_back(d);
          poly_list.push_back(new Derived2(d));


          Also, please, instead of using raw pointers, please, use std::unique_ptr smart pointer, so you will not leak memory if forgetting of doing delete, just as you are doing in your example.






          share|improve this answer





















            Your Answer






            StackExchange.ifUsing("editor", function () {
            StackExchange.using("externalEditor", function () {
            StackExchange.using("snippets", function () {
            StackExchange.snippets.init();
            });
            });
            }, "code-snippets");

            StackExchange.ready(function() {
            var channelOptions = {
            tags: "".split(" "),
            id: "1"
            };
            initTagRenderer("".split(" "), "".split(" "), channelOptions);

            StackExchange.using("externalEditor", function() {
            // Have to fire editor after snippets, if snippets enabled
            if (StackExchange.settings.snippets.snippetsEnabled) {
            StackExchange.using("snippets", function() {
            createEditor();
            });
            }
            else {
            createEditor();
            }
            });

            function createEditor() {
            StackExchange.prepareEditor({
            heartbeatType: 'answer',
            convertImagesToLinks: true,
            noModals: true,
            showLowRepImageUploadWarning: true,
            reputationToPostImages: 10,
            bindNavPrevention: true,
            postfix: "",
            imageUploader: {
            brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
            contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
            allowUrls: true
            },
            onDemand: true,
            discardSelector: ".discard-answer"
            ,immediatelyShowMarkdownHelp:true
            });


            }
            });














             

            draft saved


            draft discarded


















            StackExchange.ready(
            function () {
            StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53351649%2fpolymorphic-list-and-pointers%23new-answer', 'question_page');
            }
            );

            Post as a guest















            Required, but never shown

























            1 Answer
            1






            active

            oldest

            votes








            1 Answer
            1






            active

            oldest

            votes









            active

            oldest

            votes






            active

            oldest

            votes








            up vote
            0
            down vote



            accepted










            Yes, take a pointer of Derived1 before pushing it into the list:



            vector<Master*> poly_list;

            Derived1 *d=new Derived1();
            poly_list.push_back(d);
            poly_list.push_back(new Derived2(d));


            Also, please, instead of using raw pointers, please, use std::unique_ptr smart pointer, so you will not leak memory if forgetting of doing delete, just as you are doing in your example.






            share|improve this answer

























              up vote
              0
              down vote



              accepted










              Yes, take a pointer of Derived1 before pushing it into the list:



              vector<Master*> poly_list;

              Derived1 *d=new Derived1();
              poly_list.push_back(d);
              poly_list.push_back(new Derived2(d));


              Also, please, instead of using raw pointers, please, use std::unique_ptr smart pointer, so you will not leak memory if forgetting of doing delete, just as you are doing in your example.






              share|improve this answer























                up vote
                0
                down vote



                accepted







                up vote
                0
                down vote



                accepted






                Yes, take a pointer of Derived1 before pushing it into the list:



                vector<Master*> poly_list;

                Derived1 *d=new Derived1();
                poly_list.push_back(d);
                poly_list.push_back(new Derived2(d));


                Also, please, instead of using raw pointers, please, use std::unique_ptr smart pointer, so you will not leak memory if forgetting of doing delete, just as you are doing in your example.






                share|improve this answer












                Yes, take a pointer of Derived1 before pushing it into the list:



                vector<Master*> poly_list;

                Derived1 *d=new Derived1();
                poly_list.push_back(d);
                poly_list.push_back(new Derived2(d));


                Also, please, instead of using raw pointers, please, use std::unique_ptr smart pointer, so you will not leak memory if forgetting of doing delete, just as you are doing in your example.







                share|improve this answer












                share|improve this answer



                share|improve this answer










                answered Nov 17 at 15:14









                LoPiTaL

                1,511914




                1,511914






























                     

                    draft saved


                    draft discarded



















































                     


                    draft saved


                    draft discarded














                    StackExchange.ready(
                    function () {
                    StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53351649%2fpolymorphic-list-and-pointers%23new-answer', 'question_page');
                    }
                    );

                    Post as a guest















                    Required, but never shown





















































                    Required, but never shown














                    Required, but never shown












                    Required, but never shown







                    Required, but never shown

































                    Required, but never shown














                    Required, but never shown












                    Required, but never shown







                    Required, but never shown







                    Popular posts from this blog

                    If I really need a card on my start hand, how many mulligans make sense? [duplicate]

                    Alcedinidae

                    Can an atomic nucleus contain both particles and antiparticles? [duplicate]