Empty rows inserted into table after vba XML import











up vote
0
down vote

favorite












I'm trying to write a macro that import specific XML data into an existing XML map in an Excel file with predefined columns. Not all XML data is supposed to be imported into the sheet. I've used this approach below before without issue. However, I noticed that the macro took a awful long time to run and then I realized, that the table containing the XML data after the end of XML data inserted empty rows all the way to end row of the Excel sheet. When I import manually, this doesn't happen.



How do I ensure that the table holding the xml data isn't expanded to the end of the Excel sheet? Am I overlooking something?



My macro code:



Sub importXML()

'Define worksheets
Dim ws1 As Worksheet: Set ws1 = Sheets("XML_data")

Application.ScreenUpdating = False

'Finding last row in tabel
lastRow = ws1.Range("A1").Offset(ws1.Rows.Count - 1, 0).End(xlUp).Row

'Deleting old xml map data
If lastRow > 2 Then
ws1.Range("A2:H" & lastRow).EntireRow.Delete
End If

'Define separators and apply.
Application.DecimalSeparator = "."
Application.ThousandsSeparator = ","
Application.UseSystemSeparators = False

fileToOpen = Application.GetOpenFilename("XML Files (*.xml), *.xml", , "Import XML", , True)

Application.DisplayAlerts = False
If IsArray(fileToOpen) Then
For Each fil In fileToOpen
ActiveWorkbook.XmlMaps("myXmlMap").Import URL:=fil
Next fil
Else
Exit Sub
End If
Application.DisplayAlerts = True

Application.UseSystemSeparators = True

End Sub









share|improve this question




























    up vote
    0
    down vote

    favorite












    I'm trying to write a macro that import specific XML data into an existing XML map in an Excel file with predefined columns. Not all XML data is supposed to be imported into the sheet. I've used this approach below before without issue. However, I noticed that the macro took a awful long time to run and then I realized, that the table containing the XML data after the end of XML data inserted empty rows all the way to end row of the Excel sheet. When I import manually, this doesn't happen.



    How do I ensure that the table holding the xml data isn't expanded to the end of the Excel sheet? Am I overlooking something?



    My macro code:



    Sub importXML()

    'Define worksheets
    Dim ws1 As Worksheet: Set ws1 = Sheets("XML_data")

    Application.ScreenUpdating = False

    'Finding last row in tabel
    lastRow = ws1.Range("A1").Offset(ws1.Rows.Count - 1, 0).End(xlUp).Row

    'Deleting old xml map data
    If lastRow > 2 Then
    ws1.Range("A2:H" & lastRow).EntireRow.Delete
    End If

    'Define separators and apply.
    Application.DecimalSeparator = "."
    Application.ThousandsSeparator = ","
    Application.UseSystemSeparators = False

    fileToOpen = Application.GetOpenFilename("XML Files (*.xml), *.xml", , "Import XML", , True)

    Application.DisplayAlerts = False
    If IsArray(fileToOpen) Then
    For Each fil In fileToOpen
    ActiveWorkbook.XmlMaps("myXmlMap").Import URL:=fil
    Next fil
    Else
    Exit Sub
    End If
    Application.DisplayAlerts = True

    Application.UseSystemSeparators = True

    End Sub









    share|improve this question


























      up vote
      0
      down vote

      favorite









      up vote
      0
      down vote

      favorite











      I'm trying to write a macro that import specific XML data into an existing XML map in an Excel file with predefined columns. Not all XML data is supposed to be imported into the sheet. I've used this approach below before without issue. However, I noticed that the macro took a awful long time to run and then I realized, that the table containing the XML data after the end of XML data inserted empty rows all the way to end row of the Excel sheet. When I import manually, this doesn't happen.



      How do I ensure that the table holding the xml data isn't expanded to the end of the Excel sheet? Am I overlooking something?



      My macro code:



      Sub importXML()

      'Define worksheets
      Dim ws1 As Worksheet: Set ws1 = Sheets("XML_data")

      Application.ScreenUpdating = False

      'Finding last row in tabel
      lastRow = ws1.Range("A1").Offset(ws1.Rows.Count - 1, 0).End(xlUp).Row

      'Deleting old xml map data
      If lastRow > 2 Then
      ws1.Range("A2:H" & lastRow).EntireRow.Delete
      End If

      'Define separators and apply.
      Application.DecimalSeparator = "."
      Application.ThousandsSeparator = ","
      Application.UseSystemSeparators = False

      fileToOpen = Application.GetOpenFilename("XML Files (*.xml), *.xml", , "Import XML", , True)

      Application.DisplayAlerts = False
      If IsArray(fileToOpen) Then
      For Each fil In fileToOpen
      ActiveWorkbook.XmlMaps("myXmlMap").Import URL:=fil
      Next fil
      Else
      Exit Sub
      End If
      Application.DisplayAlerts = True

      Application.UseSystemSeparators = True

      End Sub









      share|improve this question















      I'm trying to write a macro that import specific XML data into an existing XML map in an Excel file with predefined columns. Not all XML data is supposed to be imported into the sheet. I've used this approach below before without issue. However, I noticed that the macro took a awful long time to run and then I realized, that the table containing the XML data after the end of XML data inserted empty rows all the way to end row of the Excel sheet. When I import manually, this doesn't happen.



      How do I ensure that the table holding the xml data isn't expanded to the end of the Excel sheet? Am I overlooking something?



      My macro code:



      Sub importXML()

      'Define worksheets
      Dim ws1 As Worksheet: Set ws1 = Sheets("XML_data")

      Application.ScreenUpdating = False

      'Finding last row in tabel
      lastRow = ws1.Range("A1").Offset(ws1.Rows.Count - 1, 0).End(xlUp).Row

      'Deleting old xml map data
      If lastRow > 2 Then
      ws1.Range("A2:H" & lastRow).EntireRow.Delete
      End If

      'Define separators and apply.
      Application.DecimalSeparator = "."
      Application.ThousandsSeparator = ","
      Application.UseSystemSeparators = False

      fileToOpen = Application.GetOpenFilename("XML Files (*.xml), *.xml", , "Import XML", , True)

      Application.DisplayAlerts = False
      If IsArray(fileToOpen) Then
      For Each fil In fileToOpen
      ActiveWorkbook.XmlMaps("myXmlMap").Import URL:=fil
      Next fil
      Else
      Exit Sub
      End If
      Application.DisplayAlerts = True

      Application.UseSystemSeparators = True

      End Sub






      excel xml vba excel-vba






      share|improve this question















      share|improve this question













      share|improve this question




      share|improve this question








      edited Nov 19 at 12:56









      Pᴇʜ

      19.9k42650




      19.9k42650










      asked Nov 19 at 11:46









      reuss

      3618




      3618





























          active

          oldest

          votes











          Your Answer






          StackExchange.ifUsing("editor", function () {
          StackExchange.using("externalEditor", function () {
          StackExchange.using("snippets", function () {
          StackExchange.snippets.init();
          });
          });
          }, "code-snippets");

          StackExchange.ready(function() {
          var channelOptions = {
          tags: "".split(" "),
          id: "1"
          };
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function() {
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled) {
          StackExchange.using("snippets", function() {
          createEditor();
          });
          }
          else {
          createEditor();
          }
          });

          function createEditor() {
          StackExchange.prepareEditor({
          heartbeatType: 'answer',
          convertImagesToLinks: true,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: 10,
          bindNavPrevention: true,
          postfix: "",
          imageUploader: {
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          },
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          });


          }
          });














          draft saved

          draft discarded


















          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53373980%2fempty-rows-inserted-into-table-after-vba-xml-import%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown






























          active

          oldest

          votes













          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes
















          draft saved

          draft discarded




















































          Thanks for contributing an answer to Stack Overflow!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          To learn more, see our tips on writing great answers.





          Some of your past answers have not been well-received, and you're in danger of being blocked from answering.


          Please pay close attention to the following guidance:


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53373980%2fempty-rows-inserted-into-table-after-vba-xml-import%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          "Incorrect syntax near the keyword 'ON'. (on update cascade, on delete cascade,)

          Alcedinidae

          RAC Tourist Trophy