Active Links in Gatsby seems broken with trailing slashes
I want to highlight my item when I'm on the right page, so I'm using this code :
const isActive = ({ isCurrent }) => {
return isCurrent ? { className: "active" } : null
}
<Link getProps={isActive} to="/post">Articles</Link>
It works for /post but doesn't work for /post/
How to fix that for both case please?
I'm using :
gatsby-link: https://www.npmjs.com/package/gatsby-link
which use: https://reach.tech/router/example/active-links
javascript reactjs gatsby
asked Nov 20 '18 at 9:23
Steffi
3,021155894
add a comment |
I want to highlight my item when I'm on the right page, so I'm using this code :
const isActive = ({ isCurrent }) => {
return isCurrent ? { className: "active" } : null
}
<Link getProps={isActive} to="/post">Articles</Link>
It works for /post but doesn't work for /post/
How to fix that for both case please?
I'm using :
gatsby-link: https://www.npmjs.com/package/gatsby-link
which use: https://reach.tech/router/example/active-links
javascript reactjs gatsby
asked Nov 20 '18 at 9:23
Steffi
3,021155894
1
Could you please add a bit more code? I tried to run it locally but then I'm getting error:React does not recognize the getProps prop on a DOM element.
– Dominik Krzywiecki
Nov 20 '18 at 9:41
@DominikKrzywiecki okay thanks. I update my question
– Steffi
Nov 20 '18 at 9:46
add a comment |
I want to highlight my item when I'm on the right page, so I'm using this code :
const isActive = ({ isCurrent }) => {
return isCurrent ? { className: "active" } : null
}
<Link getProps={isActive} to="/post">Articles</Link>
It works for /post but doesn't work for /post/
How to fix that for both case please?
I'm using :
gatsby-link: https://www.npmjs.com/package/gatsby-link
which use: https://reach.tech/router/example/active-links
javascript reactjs gatsby
asked Nov 20 '18 at 9:23
Steffi
3,021155894
I want to highlight my item when I'm on the right page, so I'm using this code :
const isActive = ({ isCurrent }) => {
return isCurrent ? { className: "active" } : null
}
<Link getProps={isActive} to="/post">Articles</Link>
It works for /post but doesn't work for /post/
How to fix that for both case please?
I'm using :
gatsby-link: https://www.npmjs.com/package/gatsby-link
which use: https://reach.tech/router/example/active-links
javascript reactjs gatsby
javascript reactjs gatsby
asked Nov 20 '18 at 9:23
Steffi
3,021155894
asked Nov 20 '18 at 9:23
Steffi
3,021155894
edited Nov 20 '18 at 9:45
asked Nov 20 '18 at 9:23
Steffi
3,021155894
asked Nov 20 '18 at 9:23
Steffi
3,021155894
asked Nov 20 '18 at 9:23
Steffi
3,021155894
3,021155894
1
Could you please add a bit more code? I tried to run it locally but then I'm getting error:React does not recognize the getProps prop on a DOM element.
– Dominik Krzywiecki
Nov 20 '18 at 9:41
@DominikKrzywiecki okay thanks. I update my question
– Steffi
Nov 20 '18 at 9:46
add a comment |
1
Could you please add a bit more code? I tried to run it locally but then I'm getting error:React does not recognize the getProps prop on a DOM element.
– Dominik Krzywiecki
Nov 20 '18 at 9:41
@DominikKrzywiecki okay thanks. I update my question
– Steffi
Nov 20 '18 at 9:46
1
1
Could you please add a bit more code? I tried to run it locally but then I'm getting error:
React does not recognize the getProps prop on a DOM element.– Dominik Krzywiecki
Nov 20 '18 at 9:41
Could you please add a bit more code? I tried to run it locally but then I'm getting error:
React does not recognize the getProps prop on a DOM element.– Dominik Krzywiecki
Nov 20 '18 at 9:41
@DominikKrzywiecki okay thanks. I update my question
– Steffi
Nov 20 '18 at 9:46
@DominikKrzywiecki okay thanks. I update my question
– Steffi
Nov 20 '18 at 9:46
add a comment |
1 Answer
1
active
oldest
votes
Ok, so there is a plugin https://github.com/gatsbyjs/gatsby/tree/master/packages/gatsby-plugin-remove-trailing-slashes which will remove trailing slashes from URL and I believe that this is the right solution.
If for some reason you don't want to install this dependency, you can customize your isActive function, get href param and compare with window.location.pathname (firstly remove the trailing slash from last one) and then this will also work but I strongly recommend the first solution.
answered Nov 20 '18 at 10:34
Dominik Krzywiecki
30329
add a comment |
Your Answer
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53389817%2factive-links-in-gatsby-seems-broken-with-trailing-slashes%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
1 Answer
1
active
oldest
votes
1 Answer
1
active
oldest
votes
active
oldest
votes
active
oldest
votes
Ok, so there is a plugin https://github.com/gatsbyjs/gatsby/tree/master/packages/gatsby-plugin-remove-trailing-slashes which will remove trailing slashes from URL and I believe that this is the right solution.
If for some reason you don't want to install this dependency, you can customize your isActive function, get href param and compare with window.location.pathname (firstly remove the trailing slash from last one) and then this will also work but I strongly recommend the first solution.
answered Nov 20 '18 at 10:34
Dominik Krzywiecki
30329
add a comment |
Ok, so there is a plugin https://github.com/gatsbyjs/gatsby/tree/master/packages/gatsby-plugin-remove-trailing-slashes which will remove trailing slashes from URL and I believe that this is the right solution.
If for some reason you don't want to install this dependency, you can customize your isActive function, get href param and compare with window.location.pathname (firstly remove the trailing slash from last one) and then this will also work but I strongly recommend the first solution.
answered Nov 20 '18 at 10:34
Dominik Krzywiecki
30329
add a comment |
Ok, so there is a plugin https://github.com/gatsbyjs/gatsby/tree/master/packages/gatsby-plugin-remove-trailing-slashes which will remove trailing slashes from URL and I believe that this is the right solution.
If for some reason you don't want to install this dependency, you can customize your isActive function, get href param and compare with window.location.pathname (firstly remove the trailing slash from last one) and then this will also work but I strongly recommend the first solution.
answered Nov 20 '18 at 10:34
Dominik Krzywiecki
30329
Ok, so there is a plugin https://github.com/gatsbyjs/gatsby/tree/master/packages/gatsby-plugin-remove-trailing-slashes which will remove trailing slashes from URL and I believe that this is the right solution.
If for some reason you don't want to install this dependency, you can customize your isActive function, get href param and compare with window.location.pathname (firstly remove the trailing slash from last one) and then this will also work but I strongly recommend the first solution.
answered Nov 20 '18 at 10:34
Dominik Krzywiecki
30329
answered Nov 20 '18 at 10:34
Dominik Krzywiecki
30329
answered Nov 20 '18 at 10:34
Dominik Krzywiecki
30329
answered Nov 20 '18 at 10:34
Dominik Krzywiecki
30329
30329
add a comment |
add a comment |
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Some of your past answers have not been well-received, and you're in danger of being blocked from answering.
Please pay close attention to the following guidance:
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53389817%2factive-links-in-gatsby-seems-broken-with-trailing-slashes%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
1
Could you please add a bit more code? I tried to run it locally but then I'm getting error:
React does not recognize the getProps prop on a DOM element.– Dominik Krzywiecki
Nov 20 '18 at 9:41
@DominikKrzywiecki okay thanks. I update my question
– Steffi
Nov 20 '18 at 9:46