Signal not catched by QSignalSpy












1














I'm currently coding some unit tests for one of my classes. However, I quickly ran into an issue. It seems that QSignalSpy sometimes does not catch the disconnected() signal emitted by my Client class. Here's my unit test:



void ClientTest::test_disconnectFromHost()
{
QTcpServer server;
server.listen(QHostAddress::Any, 65000);

QTcpSocket* clientSocket = new QTcpSocket();
QSignalSpy connectedSpy(clientSocket, SIGNAL(connected()));

clientSocket->connectToHost(QHostAddress::Any, 65000);
if (!connectedSpy.wait()) {
QFAIL("Client socket connection failed.");
}

Chat::Client client(clientSocket);
QSignalSpy disconnectedSpy(clientSocket, SIGNAL(disconnected()));

// Return true if disconnection succeded
QVERIFY(client.disconnectFromHost());
QVERIFY(disconnectedSpy.wait(500)); // RETURNS FALSE!

// Return false if client was not connected
QVERIFY(!client.disconnectFromHost());
QCOMPARE(client.getLastError(),
Chat::Client::Error::NotConnected);

clientSocket->connectToHost(QHostAddress::Any, 65000);
if (!connectedSpy.wait()) {
QFAIL("Client socket connection failed.");
}

QTcpSocket* serverSocket = server.nextPendingConnection();
serverSocket->disconnectFromHost(); // RETURNS FALSE!

// Emit disconnected if the server closed the connection
QVERIFY(disconnectedSpy.wait(500));

delete serverSocket;
}


And here are the related class methods:



Client::Client(QTcpSocket* socket, QObject* parent)
: QObject(parent)
{
this->socket = socket;
messageSize = -1;

lastError = None;
lastErrorString = "";

connect(socket, SIGNAL(connected()), this, SLOT(onSocketConnected()));
connect(socket, SIGNAL(disconnected()), this, SLOT(onSocketDisconnected()));
connect(socket, SIGNAL(error(QAbstractSocket::SocketError)), this, SLOT(onSocketError(QAbstractSocket::SocketError)));
connect(socket, SIGNAL(readyRead()), this, SLOT(onDataReceived()));
}

bool Client::connectToHost(const QHostAddress& serverAddress, quint16 serverPort)
{
if (socket->state() != QTcpSocket::SocketState::UnconnectedState) {
lastError = AlreadyConnected;
return false;
}

messageSize = -1;

socket->connectToHost(serverAddress, serverPort);
return true;
}

bool Client::disconnectFromHost()
{
if (socket->state() != QTcpSocket::SocketState::ConnectedState) {
lastError = NotConnected;
return false;
}

socket->disconnectFromHost();
return true;
}

void Client::onSocketConnected()
{
emit connected();
}

void Client::onSocketDisconnected()
{
emit disconnected();
}

[...]


Does anyone have an explanation as to why the QSignalSpy.wait() method returns false even if, by debugging the unit test, I know that the disconnected() signal is emitted?



Thanks!










share|improve this question





























    1














    I'm currently coding some unit tests for one of my classes. However, I quickly ran into an issue. It seems that QSignalSpy sometimes does not catch the disconnected() signal emitted by my Client class. Here's my unit test:



    void ClientTest::test_disconnectFromHost()
    {
    QTcpServer server;
    server.listen(QHostAddress::Any, 65000);

    QTcpSocket* clientSocket = new QTcpSocket();
    QSignalSpy connectedSpy(clientSocket, SIGNAL(connected()));

    clientSocket->connectToHost(QHostAddress::Any, 65000);
    if (!connectedSpy.wait()) {
    QFAIL("Client socket connection failed.");
    }

    Chat::Client client(clientSocket);
    QSignalSpy disconnectedSpy(clientSocket, SIGNAL(disconnected()));

    // Return true if disconnection succeded
    QVERIFY(client.disconnectFromHost());
    QVERIFY(disconnectedSpy.wait(500)); // RETURNS FALSE!

    // Return false if client was not connected
    QVERIFY(!client.disconnectFromHost());
    QCOMPARE(client.getLastError(),
    Chat::Client::Error::NotConnected);

    clientSocket->connectToHost(QHostAddress::Any, 65000);
    if (!connectedSpy.wait()) {
    QFAIL("Client socket connection failed.");
    }

    QTcpSocket* serverSocket = server.nextPendingConnection();
    serverSocket->disconnectFromHost(); // RETURNS FALSE!

    // Emit disconnected if the server closed the connection
    QVERIFY(disconnectedSpy.wait(500));

    delete serverSocket;
    }


    And here are the related class methods:



    Client::Client(QTcpSocket* socket, QObject* parent)
    : QObject(parent)
    {
    this->socket = socket;
    messageSize = -1;

    lastError = None;
    lastErrorString = "";

    connect(socket, SIGNAL(connected()), this, SLOT(onSocketConnected()));
    connect(socket, SIGNAL(disconnected()), this, SLOT(onSocketDisconnected()));
    connect(socket, SIGNAL(error(QAbstractSocket::SocketError)), this, SLOT(onSocketError(QAbstractSocket::SocketError)));
    connect(socket, SIGNAL(readyRead()), this, SLOT(onDataReceived()));
    }

    bool Client::connectToHost(const QHostAddress& serverAddress, quint16 serverPort)
    {
    if (socket->state() != QTcpSocket::SocketState::UnconnectedState) {
    lastError = AlreadyConnected;
    return false;
    }

    messageSize = -1;

    socket->connectToHost(serverAddress, serverPort);
    return true;
    }

    bool Client::disconnectFromHost()
    {
    if (socket->state() != QTcpSocket::SocketState::ConnectedState) {
    lastError = NotConnected;
    return false;
    }

    socket->disconnectFromHost();
    return true;
    }

    void Client::onSocketConnected()
    {
    emit connected();
    }

    void Client::onSocketDisconnected()
    {
    emit disconnected();
    }

    [...]


    Does anyone have an explanation as to why the QSignalSpy.wait() method returns false even if, by debugging the unit test, I know that the disconnected() signal is emitted?



    Thanks!










    share|improve this question



























      1












      1








      1







      I'm currently coding some unit tests for one of my classes. However, I quickly ran into an issue. It seems that QSignalSpy sometimes does not catch the disconnected() signal emitted by my Client class. Here's my unit test:



      void ClientTest::test_disconnectFromHost()
      {
      QTcpServer server;
      server.listen(QHostAddress::Any, 65000);

      QTcpSocket* clientSocket = new QTcpSocket();
      QSignalSpy connectedSpy(clientSocket, SIGNAL(connected()));

      clientSocket->connectToHost(QHostAddress::Any, 65000);
      if (!connectedSpy.wait()) {
      QFAIL("Client socket connection failed.");
      }

      Chat::Client client(clientSocket);
      QSignalSpy disconnectedSpy(clientSocket, SIGNAL(disconnected()));

      // Return true if disconnection succeded
      QVERIFY(client.disconnectFromHost());
      QVERIFY(disconnectedSpy.wait(500)); // RETURNS FALSE!

      // Return false if client was not connected
      QVERIFY(!client.disconnectFromHost());
      QCOMPARE(client.getLastError(),
      Chat::Client::Error::NotConnected);

      clientSocket->connectToHost(QHostAddress::Any, 65000);
      if (!connectedSpy.wait()) {
      QFAIL("Client socket connection failed.");
      }

      QTcpSocket* serverSocket = server.nextPendingConnection();
      serverSocket->disconnectFromHost(); // RETURNS FALSE!

      // Emit disconnected if the server closed the connection
      QVERIFY(disconnectedSpy.wait(500));

      delete serverSocket;
      }


      And here are the related class methods:



      Client::Client(QTcpSocket* socket, QObject* parent)
      : QObject(parent)
      {
      this->socket = socket;
      messageSize = -1;

      lastError = None;
      lastErrorString = "";

      connect(socket, SIGNAL(connected()), this, SLOT(onSocketConnected()));
      connect(socket, SIGNAL(disconnected()), this, SLOT(onSocketDisconnected()));
      connect(socket, SIGNAL(error(QAbstractSocket::SocketError)), this, SLOT(onSocketError(QAbstractSocket::SocketError)));
      connect(socket, SIGNAL(readyRead()), this, SLOT(onDataReceived()));
      }

      bool Client::connectToHost(const QHostAddress& serverAddress, quint16 serverPort)
      {
      if (socket->state() != QTcpSocket::SocketState::UnconnectedState) {
      lastError = AlreadyConnected;
      return false;
      }

      messageSize = -1;

      socket->connectToHost(serverAddress, serverPort);
      return true;
      }

      bool Client::disconnectFromHost()
      {
      if (socket->state() != QTcpSocket::SocketState::ConnectedState) {
      lastError = NotConnected;
      return false;
      }

      socket->disconnectFromHost();
      return true;
      }

      void Client::onSocketConnected()
      {
      emit connected();
      }

      void Client::onSocketDisconnected()
      {
      emit disconnected();
      }

      [...]


      Does anyone have an explanation as to why the QSignalSpy.wait() method returns false even if, by debugging the unit test, I know that the disconnected() signal is emitted?



      Thanks!










      share|improve this question















      I'm currently coding some unit tests for one of my classes. However, I quickly ran into an issue. It seems that QSignalSpy sometimes does not catch the disconnected() signal emitted by my Client class. Here's my unit test:



      void ClientTest::test_disconnectFromHost()
      {
      QTcpServer server;
      server.listen(QHostAddress::Any, 65000);

      QTcpSocket* clientSocket = new QTcpSocket();
      QSignalSpy connectedSpy(clientSocket, SIGNAL(connected()));

      clientSocket->connectToHost(QHostAddress::Any, 65000);
      if (!connectedSpy.wait()) {
      QFAIL("Client socket connection failed.");
      }

      Chat::Client client(clientSocket);
      QSignalSpy disconnectedSpy(clientSocket, SIGNAL(disconnected()));

      // Return true if disconnection succeded
      QVERIFY(client.disconnectFromHost());
      QVERIFY(disconnectedSpy.wait(500)); // RETURNS FALSE!

      // Return false if client was not connected
      QVERIFY(!client.disconnectFromHost());
      QCOMPARE(client.getLastError(),
      Chat::Client::Error::NotConnected);

      clientSocket->connectToHost(QHostAddress::Any, 65000);
      if (!connectedSpy.wait()) {
      QFAIL("Client socket connection failed.");
      }

      QTcpSocket* serverSocket = server.nextPendingConnection();
      serverSocket->disconnectFromHost(); // RETURNS FALSE!

      // Emit disconnected if the server closed the connection
      QVERIFY(disconnectedSpy.wait(500));

      delete serverSocket;
      }


      And here are the related class methods:



      Client::Client(QTcpSocket* socket, QObject* parent)
      : QObject(parent)
      {
      this->socket = socket;
      messageSize = -1;

      lastError = None;
      lastErrorString = "";

      connect(socket, SIGNAL(connected()), this, SLOT(onSocketConnected()));
      connect(socket, SIGNAL(disconnected()), this, SLOT(onSocketDisconnected()));
      connect(socket, SIGNAL(error(QAbstractSocket::SocketError)), this, SLOT(onSocketError(QAbstractSocket::SocketError)));
      connect(socket, SIGNAL(readyRead()), this, SLOT(onDataReceived()));
      }

      bool Client::connectToHost(const QHostAddress& serverAddress, quint16 serverPort)
      {
      if (socket->state() != QTcpSocket::SocketState::UnconnectedState) {
      lastError = AlreadyConnected;
      return false;
      }

      messageSize = -1;

      socket->connectToHost(serverAddress, serverPort);
      return true;
      }

      bool Client::disconnectFromHost()
      {
      if (socket->state() != QTcpSocket::SocketState::ConnectedState) {
      lastError = NotConnected;
      return false;
      }

      socket->disconnectFromHost();
      return true;
      }

      void Client::onSocketConnected()
      {
      emit connected();
      }

      void Client::onSocketDisconnected()
      {
      emit disconnected();
      }

      [...]


      Does anyone have an explanation as to why the QSignalSpy.wait() method returns false even if, by debugging the unit test, I know that the disconnected() signal is emitted?



      Thanks!







      qt unit-testing c++11 qsignalspy






      share|improve this question















      share|improve this question













      share|improve this question




      share|improve this question








      edited Nov 20 at 2:52









      TrebuchetMS

      1,9841618




      1,9841618










      asked Nov 20 at 1:55









      mathlizee

      112




      112





























          active

          oldest

          votes











          Your Answer






          StackExchange.ifUsing("editor", function () {
          StackExchange.using("externalEditor", function () {
          StackExchange.using("snippets", function () {
          StackExchange.snippets.init();
          });
          });
          }, "code-snippets");

          StackExchange.ready(function() {
          var channelOptions = {
          tags: "".split(" "),
          id: "1"
          };
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function() {
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled) {
          StackExchange.using("snippets", function() {
          createEditor();
          });
          }
          else {
          createEditor();
          }
          });

          function createEditor() {
          StackExchange.prepareEditor({
          heartbeatType: 'answer',
          autoActivateHeartbeat: false,
          convertImagesToLinks: true,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: 10,
          bindNavPrevention: true,
          postfix: "",
          imageUploader: {
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          },
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          });


          }
          });














          draft saved

          draft discarded


















          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53385144%2fsignal-not-catched-by-qsignalspy%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown






























          active

          oldest

          votes













          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes
















          draft saved

          draft discarded




















































          Thanks for contributing an answer to Stack Overflow!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          To learn more, see our tips on writing great answers.





          Some of your past answers have not been well-received, and you're in danger of being blocked from answering.


          Please pay close attention to the following guidance:


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53385144%2fsignal-not-catched-by-qsignalspy%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          "Incorrect syntax near the keyword 'ON'. (on update cascade, on delete cascade,)

          Alcedinidae

          Origin of the phrase “under your belt”?