Argthtjtr

import random

import os

import sys



sys.setrecursionlimit(10000)



# global variable for attempts

attempts = 0                                        



# creates a 4-digit random number

def make_random_number():                           



    rand_num = random.randint(1000,9999)

    rand_num_list = [int(x) for x in str(rand_num)]



    # make sure there are no repeats in number

    while len(rand_num_list) > len(set(rand_num_list)):         

        make_random_number()



    return rand_num_list



def make_user_num():



    user_num = input("Enter a 4-digit number: ")

    user_num_list = [int(x) for x in user_num]



    return user_num_list



# compares both numbers and looks for matches, and if in the same position

def compare(rand):                             



    global attempts

    # adds to total attempts, if guessed correctly on 1st try, total attempts = 1

    attempts += 1                                   



    cows = 0

    bulls = 0



    user = make_user_num()



    if rand == user:



        print("It's a full match!", rand, "is equal to", user)

        print("It took this many attempts:", attempts)



        exit()



    while rand != user:



        print(rand)



        # calculates cows 

        for x in range(4):          



            if rand[x] == user[x]:

                cows += 1



        # calculates bulls        

        for i in range(4):



            for j in range(4):



                if user[i] == rand[j]:

                    bulls += 1

I think the for loop calculating the amount of cows(numbers match and also have the same position) is correct, but the one calculating the bulls(numbers match but have different positions), is incorrect. Is my logic correct for calculating the amount of bulls?