Argthtjtr

I am making a game library system for a project and trying to implement a search function which would display the user games that they are searching for.

I have two models called Game and GameInformation. This is due to many games having the same information, i.e. being the same game. The migration files look like:

GameInformation

<?php



use IlluminateSupportFacadesSchema;

use IlluminateDatabaseSchemaBlueprint;

use IlluminateDatabaseMigrationsMigration;



class CreateGameInformationTable extends Migration

{

    /**

     * Run the migrations.

     *

     * @return void

     */

    public function up()

    {

        Schema::create('game_information', function (Blueprint $table) {

            $table->increments('id');

            $table->string('title');

            $table->text('description');

            $table->string('genre');

            $table->timestamps();

        });

    }



    /**

     * Reverse the migrations.

     *

     * @return void

     */

    public function down()

    {

        Schema::dropIfExists('Game_Information');

    }

}

Game

<?php



use IlluminateSupportFacadesSchema;

use IlluminateDatabaseSchemaBlueprint;

use IlluminateDatabaseMigrationsMigration;



class CreateGamesTable extends Migration

{

    /**

     * Run the migrations.

     *

     * @return void

     */

    public function up()

    {

        Schema::create('games', function (Blueprint $table) {

            $table->increments('id');

            $table->integer('info_id')->unsigned();

            $table->foreign('info_id')->references('id')->on('game_information');

            $table->enum('type', ['disc', 'cartridge']);

            $table->integer('platform_id')->unsigned();

            $table->foreign('platform_id')->references('id')->on('platforms');

            $table->integer('price');

            $table->year('year_released');

            $table->boolean('available')->default(true);

            $table->timestamps();

        });

    }



    /**

     * Reverse the migrations.

     *

     * @return void

     */

    public function down()

    {

        Schema::dropIfExists('Games');

    }

}

So what should happen once the user has called a search, it should retrieve the all the game informations that match their query, and then loop through them all and find the games that are associated with that information. In the end it should return an array of arrays where the inner arrays contain the game and the game information objects.

Search bar

<form class="form-inline" action="/search" method="POST" role="/search">

    {{ csrf_field() }}

    <div class="input-group">

        <input type="text" class="form-control" name="q" placeholder="Search">

    </div>

</form>

Search function in SearchController

public function search() {

  $q = Input::get ( 'q' );

  if(strlen($q) == 0 || strpos($q, '%') !== false) { // For security

    return view ('home')->with('failureMsg','Nothing was found...');

  }

  $infos = GameInformation::where('title', 'like', '%' . $q .'%')->get();

  $games = array();

  foreach($infos as $info) {

    $gamesWithInfo = $info->games();

    array_push($games, array($info, $gamesWithInfo));

  }

  if (count ( $games ) > 0)

      return view ('home')->with( $games )->withQuery($q);

  else

      return view ('home')->with('failureMsg','Nothing was found...');

}

Display search results

<div class="card">

    <div class="card-header">Dashboard</div>

    <div class="card-body">

      <div class="container">

        <div class="row">

        </div>

          @if(!empty($failureMsg))

          <div class="alert alert-failure"> {{ $failureMsg }}</div>

          @endif

          @if(isset($games))

          HELLO

              <p> The search results for your query <b> {{ $query }} </b> are :</p>

          <h2>Games found:</h2>

          <table class="table table-striped">

              <thead>

                  <tr>

                      <th>Title</th>

                      <th>Description</th>

                  </tr>

              </thead>

              <tbody>

                  @foreach($games as $game)

                  <tr>

                      <td>{{$game(0)->title}}</td>

                      <td>{{$game(0)->description}}</td>

                  </tr>

                  @endforeach

              </tbody>

          </table>

          @endif

      </div>

    </div>

</div>

It doesn't display anything when a correct query is input, however it does display an error message when an incorrect one is input. So I'm thinking it's return an array of empty arrays.

Also in the SearchController on the line:

$infos = GameInformation::where('title', 'like', '%' . $q .'%')->get();

I have also tried making it:

$infos = GameInformation::where('title', 'like', '%' . $q .'%');

But that will return the error message where nothing is found.

Also the models:

Game

<?php



namespace App;



use IlluminateDatabaseEloquentModel;

use Eloquent;



class Game extends Eloquent

{

  protected $primaryKey = 'id';



  public function information() {

    return $this->belongsTo('AppGameInformation');

  }

}

GameInformation

<?php



namespace App;



use IlluminateDatabaseEloquentModel;

use Eloquent;



class GameInformation extends Eloquent

{

    protected $table = 'game_information';

    protected $primaryKey = 'id';



    public function games() {

      return $this->hasMany('AppGame', 'info_id');

    }

}

To start, verify the value of $q is what you are expecting to make sure the first condition isn't getting tripped:

$q = Input::get ( 'q' );

dd($q); // temporarily to verify the value

if(strlen($q) == 0 || strpos($q, '%') !== false) {

    return view ('home')->with('failureMsg','Nothing was found...');

}

Then verify that you are getting the correct results from your query:

$infos = GameInformation::where('title', 'like', '%' . $q .'%')->get();

dd($infos); // temporarily to verify at least one item is found

If you are going through your foreach($infos as $info) loop at least once, then there should be at least one item in your $games array. If $games is empty, then you will hit your the second error condition.

Another issue:

$gamesWithInfo = $info->games();

You need to actually fetch the games. With your current code you could do it like this:

$gamesWithInfo = $info->games()->get();

Or just:

$gamesWithInfo = $info->games;

But it would be better to eager load them:

$infos = GameInformation::with('games')

    ->where('title', 'like', '%' . $q .'%')->get();

Then use:

$gamesWithInfo = $info->games;

Inside your loop.

So I have changed my search function to this:

public function search() {

  $q = Input::get ( 'q' );

  if(strlen($q) == 0 || strpos($q, '%') !== false) { // For security

    return view ('home')->with('failureMsg','Nothing was found...');

  }

  $infos = GameInformation::with('games')->where('title', 'like', '%' . $q .'%')->get();

  $games = array();

  foreach($infos as $info) {

    $gamesWithInfo = $info->games;

    array_push($games, array($info, $gamesWithInfo));

  }

  if (count ( $games ) > 0)

      return view ('home')->with( $games )->withQuery($q);

  else

      return view ('home')->with('failureMsg','Nothing was found...');

}

But I'm getting no output as before. I also did the dd() and the input was correct and infos array was not empty.

The output on the site looks like this when nothing is found:

But it's returning this when something is found:

I have seemed to fix the problem, it seems as $games was not being recognised so when I was returning the view I changed it to:

return view ('home')->with('gamesAndInfo', $gamesWithInfo )->withQuery($q);

And now it is being set properly.