OkHttp Call timeout from Retrofit Interceptor using Annotations is not applied
I'm trying to use a recently added feature from OkHttp 3.12.0: full-operation timeouts.
For that, I also rely on the new Invocation class from retrofit 2.5.0 that allows me to retrieve the method annotations.
The annotation is:
@Retention(RetentionPolicy.RUNTIME)
@Target(ElementType.METHOD)
public @interface Timeout {
int value();
TimeUnit unit();
}
The retrofit interface is:
public interface AgentApi {
@Timeout(value = 100, unit = TimeUnit.MILLISECONDS)
@GET("something")
Call<String> getSomething();
}
And the interceptor is:
class TimeoutInterceptor implements Interceptor {
@NonNull
@Override
public Response intercept(@NonNull Chain chain) throws IOException {
Request request = chain.request();
final Invocation tag = request.tag(Invocation.class);
final Method method = tag != null ? tag.method() : null;
final Timeout timeout = method != null ? method.getAnnotation(Timeout.class) : null;
if (timeout != null) {
chain.call().timeout().timeout(timeout.value(), timeout.unit());
}
return chain.proceed(request);
}
}
I've correctly added the TimeoutInterceptor with .addInterceptor(...) in the OkHttpClient provided to the Retrofit Builder.
Unfortunately, it doesn't work as I expected. The calls are not failing when the timeout is reached?
Though it works fine when using the chain methods from the interceptor:
chain
.withConnectTimeout(connect, unit)
.withReadTimeout(read, unit)
.withWriteTimeout(write, unit)
Is this because the call timeout must be set before the call is enqueued? (and the Interceptor is triggered too late in the process?), or is this something else?
android retrofit retrofit2 okhttp okhttp3 asked Nov 21 '18 at 14:03
Simon MarquisSimon Marquis
5,13811632
add a comment |
I'm trying to use a recently added feature from OkHttp 3.12.0: full-operation timeouts.
For that, I also rely on the new Invocation class from retrofit 2.5.0 that allows me to retrieve the method annotations.
The annotation is:
@Retention(RetentionPolicy.RUNTIME)
@Target(ElementType.METHOD)
public @interface Timeout {
int value();
TimeUnit unit();
}
The retrofit interface is:
public interface AgentApi {
@Timeout(value = 100, unit = TimeUnit.MILLISECONDS)
@GET("something")
Call<String> getSomething();
}
And the interceptor is:
class TimeoutInterceptor implements Interceptor {
@NonNull
@Override
public Response intercept(@NonNull Chain chain) throws IOException {
Request request = chain.request();
final Invocation tag = request.tag(Invocation.class);
final Method method = tag != null ? tag.method() : null;
final Timeout timeout = method != null ? method.getAnnotation(Timeout.class) : null;
if (timeout != null) {
chain.call().timeout().timeout(timeout.value(), timeout.unit());
}
return chain.proceed(request);
}
}
I've correctly added the TimeoutInterceptor with .addInterceptor(...) in the OkHttpClient provided to the Retrofit Builder.
Unfortunately, it doesn't work as I expected. The calls are not failing when the timeout is reached?
Though it works fine when using the chain methods from the interceptor:
chain
.withConnectTimeout(connect, unit)
.withReadTimeout(read, unit)
.withWriteTimeout(write, unit)
Is this because the call timeout must be set before the call is enqueued? (and the Interceptor is triggered too late in the process?), or is this something else?
android retrofit retrofit2 okhttp okhttp3 asked Nov 21 '18 at 14:03
Simon MarquisSimon Marquis
5,13811632
That's really strange. I made a similiar test here and happens the same thing. It works If I use the old methods to set timeout at the interceptor, but when I try to change usingfull-operation timeoustit is ignored. It only works when I set at theOkHttpClientBuilder. At documentation it says we can should use by theOkHttpClientBuilder.callTimeout()or byCall.timeout()
– haroldolivieri
Nov 30 '18 at 12:10
add a comment |
I'm trying to use a recently added feature from OkHttp 3.12.0: full-operation timeouts.
For that, I also rely on the new Invocation class from retrofit 2.5.0 that allows me to retrieve the method annotations.
The annotation is:
@Retention(RetentionPolicy.RUNTIME)
@Target(ElementType.METHOD)
public @interface Timeout {
int value();
TimeUnit unit();
}
The retrofit interface is:
public interface AgentApi {
@Timeout(value = 100, unit = TimeUnit.MILLISECONDS)
@GET("something")
Call<String> getSomething();
}
And the interceptor is:
class TimeoutInterceptor implements Interceptor {
@NonNull
@Override
public Response intercept(@NonNull Chain chain) throws IOException {
Request request = chain.request();
final Invocation tag = request.tag(Invocation.class);
final Method method = tag != null ? tag.method() : null;
final Timeout timeout = method != null ? method.getAnnotation(Timeout.class) : null;
if (timeout != null) {
chain.call().timeout().timeout(timeout.value(), timeout.unit());
}
return chain.proceed(request);
}
}
I've correctly added the TimeoutInterceptor with .addInterceptor(...) in the OkHttpClient provided to the Retrofit Builder.
Unfortunately, it doesn't work as I expected. The calls are not failing when the timeout is reached?
Though it works fine when using the chain methods from the interceptor:
chain
.withConnectTimeout(connect, unit)
.withReadTimeout(read, unit)
.withWriteTimeout(write, unit)
Is this because the call timeout must be set before the call is enqueued? (and the Interceptor is triggered too late in the process?), or is this something else?
android retrofit retrofit2 okhttp okhttp3 asked Nov 21 '18 at 14:03
Simon MarquisSimon Marquis
5,13811632
I'm trying to use a recently added feature from OkHttp 3.12.0: full-operation timeouts.
For that, I also rely on the new Invocation class from retrofit 2.5.0 that allows me to retrieve the method annotations.
The annotation is:
@Retention(RetentionPolicy.RUNTIME)
@Target(ElementType.METHOD)
public @interface Timeout {
int value();
TimeUnit unit();
}
The retrofit interface is:
public interface AgentApi {
@Timeout(value = 100, unit = TimeUnit.MILLISECONDS)
@GET("something")
Call<String> getSomething();
}
And the interceptor is:
class TimeoutInterceptor implements Interceptor {
@NonNull
@Override
public Response intercept(@NonNull Chain chain) throws IOException {
Request request = chain.request();
final Invocation tag = request.tag(Invocation.class);
final Method method = tag != null ? tag.method() : null;
final Timeout timeout = method != null ? method.getAnnotation(Timeout.class) : null;
if (timeout != null) {
chain.call().timeout().timeout(timeout.value(), timeout.unit());
}
return chain.proceed(request);
}
}
I've correctly added the TimeoutInterceptor with .addInterceptor(...) in the OkHttpClient provided to the Retrofit Builder.
Unfortunately, it doesn't work as I expected. The calls are not failing when the timeout is reached?
Though it works fine when using the chain methods from the interceptor:
chain
.withConnectTimeout(connect, unit)
.withReadTimeout(read, unit)
.withWriteTimeout(write, unit)
Is this because the call timeout must be set before the call is enqueued? (and the Interceptor is triggered too late in the process?), or is this something else?
android retrofit retrofit2 okhttp okhttp3 android retrofit retrofit2 okhttp okhttp3 asked Nov 21 '18 at 14:03
Simon MarquisSimon Marquis
5,13811632
asked Nov 21 '18 at 14:03
Simon MarquisSimon Marquis
5,13811632
asked Nov 21 '18 at 14:03
Simon MarquisSimon Marquis
5,13811632
asked Nov 21 '18 at 14:03
Simon MarquisSimon Marquis
5,13811632
asked Nov 21 '18 at 14:03
Simon MarquisSimon Marquis
5,13811632
5,13811632
That's really strange. I made a similiar test here and happens the same thing. It works If I use the old methods to set timeout at the interceptor, but when I try to change usingfull-operation timeoustit is ignored. It only works when I set at theOkHttpClientBuilder. At documentation it says we can should use by theOkHttpClientBuilder.callTimeout()or byCall.timeout()
– haroldolivieri
Nov 30 '18 at 12:10
add a comment |
That's really strange. I made a similiar test here and happens the same thing. It works If I use the old methods to set timeout at the interceptor, but when I try to change usingfull-operation timeoustit is ignored. It only works when I set at theOkHttpClientBuilder. At documentation it says we can should use by theOkHttpClientBuilder.callTimeout()or byCall.timeout()
– haroldolivieri
Nov 30 '18 at 12:10
That's really strange. I made a similiar test here and happens the same thing. It works If I use the old methods to set timeout at the interceptor, but when I try to change using
full-operation timeoust it is ignored. It only works when I set at the OkHttpClientBuilder. At documentation it says we can should use by the OkHttpClientBuilder.callTimeout() or by Call.timeout()– haroldolivieri
Nov 30 '18 at 12:10
That's really strange. I made a similiar test here and happens the same thing. It works If I use the old methods to set timeout at the interceptor, but when I try to change using
full-operation timeoust it is ignored. It only works when I set at the OkHttpClientBuilder. At documentation it says we can should use by the OkHttpClientBuilder.callTimeout() or by Call.timeout()– haroldolivieri
Nov 30 '18 at 12:10
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53413822%2fokhttp-call-timeout-from-retrofit-interceptor-using-annotations-is-not-applied%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53413822%2fokhttp-call-timeout-from-retrofit-interceptor-using-annotations-is-not-applied%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
That's really strange. I made a similiar test here and happens the same thing. It works If I use the old methods to set timeout at the interceptor, but when I try to change using
full-operation timeoustit is ignored. It only works when I set at theOkHttpClientBuilder. At documentation it says we can should use by theOkHttpClientBuilder.callTimeout()or byCall.timeout()– haroldolivieri
Nov 30 '18 at 12:10